Issue 32121: Files under container directory are moved to @files when viewed from file browser or webdav

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:FileContent
Priority:2
Milestone:17.3
Opened:2017-11-09 14:51 by xyang
Changed:2017-11-13 13:36 by Jon (LabKey DevOps)
Resolved:2017-11-10 11:48 by xyang
Resolution:Fixed
Related:31811
Support Ticket:31811
Pull Requests:
Closed:2017-11-10 11:49 by xyang
2017-11-09 14:51 xyang
Title»Files under container directory are moved to @files when viewed from file browser or webdav
Assigned ToGuest»jeckels
Notify»steveh
Type»Defect
Area»FileContent
Priority»2
Milestone»17.3
Triage»Review Requested
Support Ticket»31811
Files that are siblings to @files directory of a container are moved from their original location to under @files when the file root is accessed from LabKey. In certain cases, those files will be deleted without moved to @files directory, as is observed by Nestle when they set "@files" symlink to point back to the container directory.

This code that does this moving/deletion was "put in place to help SCHARP migrate their file roots when we changed the layout. It was intended to last a couple of releases. Obviously, it's been in there a little longer."

We should remove this legacy workaround for release17.3.

Josh has also recommended documenting this in release note: "I also suggest that we add it to the release notes as a potential breaking change for customers. I certainly hope nobody's relying on it after all this time, but I don't know for sure. Customers can check if their TOMCAT/logs/labkey-file-copy.log has any entries. If so, then the code has been copying files, and they'd want to stop dropping files in the old location."

2017-11-09 19:39 jeckels
Assigned Tojeckels»xyang
Notifysteveh»steveh;Karl Lum
Despite the fact that I authored the patch, approving based on Karl's email earlier today. Xing, I'm out of the office tomorrow. Would you mind committing for me?

2017-11-09 19:39 jeckels
TriageReview Requested»Approved and Code Reviewed

2017-11-10 11:48 xyang
resolve as Fixed
Statusopen»resolved
Checked in to release17.3 by r55001.

2017-11-10 11:49 xyang
close
Statusresolved»closed
Assigned Toxyang»Guest
I've already buddy tested Josh's patch. Closing issue.

2017-11-13 13:36 Jon (LabKey DevOps)
Related»31811