Issue 45325: With new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Sample Manager
Priority:2
Milestone:22.07
Opened:2022-04-25 13:36 by Dan Duffek
Changed:2022-06-21 15:02 by Dan Duffek
Resolved:2022-06-10 06:47 by cnathe
Resolution:Fixed
Duplicates:45640
Support Ticket: 
Pull Requests:labkey-ui-components#854
sampleManagement#982
Closed:2022-06-21 15:02 by Dan Duffek
2022-04-25 13:36 Dan Duffek
Title»With new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page
Assigned To»triage
Notify»cnathe
Type»Defect
Area»Sample Manager
Priority»3
Milestone»22.07
Found this issue while testing the new grid menu work from the Entity Grid Actions Update story.

With this new menu options a user will be able to edit samples from new locations. When I did this the behavior was not what I was expecting when I clicked the "Edit in Grid" button in the bulk edit dialog. Rather than being sent to an editable grid populated with the selected samples I was sent back to the original page I selected the samples from.

The spec did not call out what the expected behavior should be in this case.

Example:
Go to a job that has some samples.
Go to the jobs samples page and click on the tab for a sample type.
Select some samples from the grid.
Click the Edit / Edit in Dialog grid menu option.
In the bulk edit dialog click the Edit in Grid button.

Result:
You are sent back to the jobs samples page.
Was expecting to be sent to the editable grid with the selected samples.

Also note, when you are sent back the selections are not persisted. At the very least we should persist the selection.

The attached mov file shows the behavior.
 
 Switch to Grid Edit from Bulk Edit.mov

2022-04-25 14:51 cnathe
Adding dev estimate, in case that helps with milestone/priority/scoring.

2022-04-25 15:13 hannahb
Assigned Totriage»cnathe
Notifycnathe»cnathe;Susan Hert;hannahb;hannahb
Priority3»2
Milestone22.07»22.05
We'll want to get this addressed - is 22.5 possible?

2022-04-25 15:24 cnathe
I am unlikely to get to this for 22.5 as I am focused on getting the changes in for the sample grid button/action updates. Is 22.6 OK?

2022-04-25 15:43 hannahb
Milestone22.05»22.06
Yep, that's alright thanks Cory

2022-06-03 13:58 cnathe
TitleWith new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page»**With new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page
Milestone22.06»22.07
Pull Requests»https://github.com/LabKey/labkey-ui-components/pull/854 https://github.com/LabKey/sampleManagement/pull/982

2022-06-08 07:20 xyang
Issue 45640 marked as duplicate of this issue.
2022-06-10 06:47 cnathe
resolve as Fixed
Title**With new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page»With new entity grid actions menu switching to grid edit from bulk edit dialog takes you back to originating page
Statusopen»resolved
Assigned Tocnathe»Dan Duffek
Fix has been merged and this will be in LK v22.7

2022-06-21 15:02 Dan Duffek
close
Statusresolved»closed
Assigned ToDan Duffek»Guest
Verified.