Issue 45373: Sample Finder export generates ambiguous column header names

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Sample Manager
Priority:2
Milestone:22.07
Opened:2022-04-29 12:32 by xyang
Changed:2022-06-23 10:14 by xyang
Resolved:2022-06-23 10:14 by xyang
Resolution:Fixed
Related:45366
Support Ticket: 
Pull Requests:*
labkey-ui-components#845
*
sampleManagement#968
*
platform#3395
*
biologics#1337
Closed:2022-06-23 10:14 by xyang
Related Issues
2022-04-29 12:32 xyang
Title»Sample Finder export generates ambiguous column header names
Assigned To»triage
Type»Defect
Area»Sample Manager
Priority»3
Milestone»22.07
Related»45366
When exporting result grids from Sample Finder, the exported column headers don't contain the parent/source type prefix, resulting in multiple columns with the same column name.

Repro:
Run SMSampleFinderGridTest.initFinder, then export.

Note:
after fixing this issue, please update SMSampleFinderGridTest.testExport to verify full expected data, not just sample id.
 
 GridHeader.png
 ExportedExcelHeader.png

2022-04-30 07:14 hannahb
Assigned Totriage»xyang
Notify»hannahb;Susan Hert;Dan Duffek
Priority3»2
Milestone22.07»22.06
Thanks, Xing. Let's prioritize for 22.6

2022-05-27 17:01 xyang
TitleSample Finder export generates ambiguous column header names»**Sample Finder export generates ambiguous column header names
Pull Requests»* https://github.com/LabKey/labkey-ui-components/pull/845 * https://github.com/LabKey/sampleManagement/pull/968 * https://github.com/LabKey/platform/pull/3395 * https://github.com/LabKey/biologics/pull/1337

2022-05-30 09:43 xyang
Assigned Toxyang»Dan Duffek
Dan, do you mind validating the fix? thanks.

2022-06-21 11:51 xyang
Milestone22.06»22.07

2022-06-21 14:14 Dan Duffek
Assigned ToDan Duffek»xyang
Validated in the branch.

I'm a little confused by the note (after fixing this issue, please update SMSampleFinderGridTest.testExport to verify full expected data, not just sample id.)

I stepped through SMSampleFinderGridActionsTest.testExport. In that test the call to verifyTabbedGridExport does validate all of the columns that are displayed on the grid with the excel sheet. It doesn't validate the column headers explicitly it created a list of a map with the column name as the key for the map. Each map entry in the list is constructed from a row in the grid and is then compared to the same row in the exported excel sheet. Maybe I'm missing what the ask is.

2022-06-23 10:14 xyang
resolve as Fixed
Title**Sample Finder export generates ambiguous column header names»Sample Finder export generates ambiguous column header names
Statusopen»resolved
merged

2022-06-23 10:14 xyang
close
Statusresolved»closed
Assigned Toxyang»Guest