Issue 45374: LKSM issues when site "default display format for numbers" is set

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Sample Manager
Priority:3
Milestone:22.06
Opened:2022-04-29 14:46 by cnathe
Changed:2022-05-11 08:20 by wendyi
Resolved:2022-05-02 09:51 by cnathe
Resolution:Fixed
Support Ticket: 
Pull Requests:labkey-ui-components#826
platform#3304
biologics#1275
sampleManagement#938
Closed:2022-05-11 08:20 by wendyi
2022-04-29 14:46 cnathe
Title»LKSM issues when site "default display format for numbers" is set
Assigned To»cnathe
Notify»wendyi
Type»Defect
Area»Sample Manager
Priority»3
Milestone»22.06
Reported by Wendy. If you go to the Site > Admin Console > Look and Feel Settings and set the "Default display format for numbers" to "#.##" (as an example), there are some unexpected issues that come up in the LKSM app.

1. if you go to a source or sample grid, check a row, Edit > Edit in Grid, set a value in Description or some other field, click Finish/Save -> JS error "Uncaught TypeError: Cannot read properties of undefined (reading 'toString')"

2. go to sample finder, add some filters for a sample type parent and click apply -> server side exception "java.lang.IllegalArgumentException: Cannot format given Object as a Number" (and the sample finder page just sits in a loading state)

2022-04-29 15:18 cnathe
TitleLKSM issues when site "default display format for numbers" is set»**LKSM issues when site "default display format for numbers" is set
Pull Requests»https://github.com/LabKey/labkey-ui-components/pull/826 https://github.com/LabKey/platform/pull/3304 https://github.com/LabKey/biologics/pull/1275 https://github.com/LabKey/sampleManagement/pull/938

2022-05-02 09:51 cnathe
resolve as Fixed
Title**LKSM issues when site "default display format for numbers" is set»LKSM issues when site "default display format for numbers" is set
Statusopen»resolved
Fix/changes for this have been merged and will be part of LK v22.6.

2022-05-11 06:03 cnathe
Assigned Tocnathe»wendyi
forgot to assign this back to someone to verify. Wendy, would you mind taking a look (you can use develop)?

2022-05-11 08:20 wendyi
close
Statusresolved»closed
Assigned Towendyi»Guest
works! Thanks Cory.