Issue 45396: ELN: Add comment error

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:ELN
Priority:3
Milestone:22.05
Opened:2022-05-03 09:59 by hannahb
Changed:2022-05-05 10:43 by hannahb
Resolved:2022-05-04 16:35 by Nick Kerr
Resolution:Fixed
Support Ticket: 
Pull Requests:platform#3239
Closed:2022-05-05 10:43 by hannahb
2022-05-03 09:59 hannahb
Title»ELN: Add comment error
Assigned To»alanv
Notify»hannahb;Nick Kerr;Bernie;Andrew
Type»Defect
Area»ELN
Priority»3
Milestone»22.07
I saw this while doing a demo - to repro:

- Go into an ELN
- Select Start a Thread
- Add some text
- Select "Add Comment"

You then get an error message: A "thread" object is required to create a thread.

When I open up the JS console to do this, I see this:

VM68:1 POST https://www.labkey.org/Explore/Biologics/announcements-createThread.api 400
(anonymous) @ VM68:1
M @ index.js:1785
(anonymous) @ components.js:131695
createThread @ components.js:131694
(anonymous) @ components.js:132097
(anonymous) @ components.js:131841
qfe @ components.js:131837
(anonymous) @ components.js:132076
(anonymous) @ components.js:132149
l @ react-dom.production.min.js:14
f @ react-dom.production.min.js:14
(anonymous) @ react-dom.production.min.js:14
g @ react-dom.production.min.js:15
at @ react-dom.production.min.js:52
rt @ react-dom.production.min.js:51
it @ react-dom.production.min.js:52
dt @ react-dom.production.min.js:56
L @ react-dom.production.min.js:287
U @ react-dom.production.min.js:19
Qt @ react-dom.production.min.js:70
Vt @ react-dom.production.min.js:69
e.unstable_runWithPriority @ scheduler.production.min.js:19
Go @ react-dom.production.min.js:122
A @ react-dom.production.min.js:287
qt @ react-dom.production.min.js:68



Maybe I don't need to select "Add Comment" - but either way the messaging should get better (and perhaps the buttons as well?)

2022-05-04 16:35 Nick Kerr
resolve as Fixed
Statusopen»resolved
Assigned Toalanv»hannahb
Notifyhannahb;Nick Kerr;Bernie;Andrew»hannahb;Nick Kerr;Bernie;Andrew;Matthew Bellew
Milestone22.07»22.05
Pull Requests»https://github.com/LabKey/platform/pull/3239
This was fixed with https://github.com/LabKey/platform/pull/3239 on v22.03 and is fixed in v22.05. Unfortunately, we do not bring patches forward to "point" releases so this fix "skipped" v22.04. I originally discovered this issue due to a test failure in v22.03:

https://github.com/LabKey/platform/pull/3222#issuecomment-1093127084

2022-05-05 10:43 hannahb
close
Statusresolved»closed
Assigned Tohannahb»Guest
Verified