Issue 45521: Support Checkboxes in ELN Notebooks

issues
Status:resolved
Assigned To:steveh
Type:Defect
Area: 
Priority:2
Milestone:22.06
Opened:2022-05-19 10:58 by steveh
Changed:2022-06-06 11:10 by Rob Morphew
Resolved:2022-06-06 11:10 by Rob Morphew
Resolution:Fixed
Support Ticket:45485
Pull Requests:labbook#190
sampleManagement#976
biologics#1345
Closed:
2022-05-19 10:58 steveh
Title»Support Checkboxes in ELN Notebooks
Assigned To»triage
Type»Defect
Priority»3
Milestone»22.07
Support Ticket»45485
A Biologics client would like to have checkboxes inside their notebooks, to help them work through complex task lists.

2022-05-23 11:46 hannahb
Assigned Totriage»Bernie
Notify»hannahb
I'll let Bernie chime in, but I imagine this will come at some point with more integration of workflow and ELN (ie. allowing for workflow jobs to be "checked off" within ELN)

2022-05-25 11:05 Bernie
Assigned ToBernie»alanv
Priority3»2
I do expect a reflection if not interaction of workflows in notebooks.
For the time being Alan, does our editor support a checkbox format? If so, can you add an estimate?
Thanks,
Bernie

2022-05-26 07:50 alanv
It looks like the ListExtension that we use supports checklists out of the box, so we'd just need to wire up a button in the toolbar for inserting a checklist.
 
 Screen Shot 2022-05-26 at 9.41.46 AM.png

2022-05-26 09:15 alanv
Pull Requests»https://github.com/LabKey/labbook/pull/187 https://github.com/LabKey/biologics/pull/1333
I have PRs open for this.
 
 Screen Shot 2022-05-26 at 11.04.10 AM.png

2022-05-26 12:58 Bernie
Assigned Toalanv»Bernie
Priority2»3
Milestone22.07»22.11

2022-05-26 13:03 alanv

2022-05-26 13:06 alanv
Pull Requestshttps://github.com/LabKey/labbook/pull/187 https://github.com/LabKey/biologics/pull/1333»
Due to a bug in the implementation provided by Remirror (https://github.com/remirror/remirror/issues/1657) we will need to wait for them to address the bug (which I find unlikely in the near term) or implement our own version of this plugin, which would require a considerable amount of effort on our end.

2022-05-31 13:51 alanv
Milestone22.11»22.06
Pull Requests»https://github.com/LabKey/labbook/pull/190
The remirror team fixed the bug over the weekend so I re-opened my PR and bumped the remirror dependency to include their bug fix. Task list checkboxes do no update or trigger any errors in read only mode.

2022-05-31 13:51 alanv

2022-05-31 13:58 alanv
Pull Requestshttps://github.com/LabKey/labbook/pull/190»https://github.com/LabKey/labbook/pull/190 https://github.com/LabKey/sampleManagement/pull/976 https://github.com/LabKey/biologics/pull/1345

2022-05-31 14:11 alanv
Milestone22.06»22.07
We're going to merge the PRs after 22.6 snapshot is created because the version bump for remirror includes a lot of other fixes and we want to allow this to bake for a bit before it's released to customers.

2022-05-31 16:44 Bernie
Priority3»2
Milestone22.07»22.06
Wonderful news! I'll look forward to testing it.

2022-06-02 13:50 Rob Morphew
Assigned ToBernie»Rob Morphew
Rob will resolve this.

2022-06-06 11:10 Rob Morphew
resolve as Fixed
Statusopen»resolved
Assigned ToRob Morphew»steveh
Looks good