Issue 45544: Clicking "View Chromatogram" from Panorama QC plot doesn't page to show desired plot

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:TargetedMS
Priority:3
Milestone:22.07
Opened:2022-05-23 17:53 by jeckels
Changed:2022-08-09 15:35 by Sweta Jewargikar
Resolved:2022-08-09 15:34 by Sweta Jewargikar
Resolution:Fixed
Support Ticket: 
Pull Requests:targetedms#543
Closed:2022-08-09 15:35 by Sweta Jewargikar
2022-05-23 17:53 jeckels
Title»Clicking "View Chromatogram" from Panorama QC plot doesn't page to show desired plot
Assigned To»jeckels
Type»Defect
Area»TargetedMS
Priority»3
Milestone»22.03
Repro:

Create a Panorama QC folder.
Import SProCoPTutorial.zip from the TargetedMS module's ./test/sampledata/TargetedMS directory.
For any of the QC metrics, hover over a data point and click View Chromatogram.
It should take you to a page showing chromatograms from the different replicates, and highlight and scroll down to the one from the data point you clicked.

However, if you click on a data point that's beyond the first page of replicates, it won't jump to right place. For this setup, that means any points beyond the first 10 in the plots won't highlight properly.

2022-05-23 18:02 jeckels

2022-05-23 18:02 jeckels
Pull Requests»https://github.com/LabKey/targetedms/pull/543

2022-05-24 09:05 jeckels
resolve as Fixed
Statusopen»resolved
Assigned Tojeckels»Sweta Jewargikar
Notify»wendyi
Sweta, can you close this one out? You can also validate that the replicate name in the QC plot tooltip matches with the title of the highlighted chromatogram plot after you click. This would be a good and quick addition to one of the existing QC automated tests.

2022-05-31 18:18 Sweta Jewargikar
close
Statusresolved»closed
Assigned ToSweta Jewargikar»Guest
Verify and test coverage added https://github.com/LabKey/targetedms/pull/547

2022-06-09 17:36 jeckels
reopen
Statusclosed»open
Assigned ToGuest»Sweta Jewargikar
The test isn't working yet and the PR isn't merged. Let's not close this until it's complete.

2022-07-07 14:42 jeckels
Milestone22.03»22.07

2022-08-09 13:48 Sweta Jewargikar
Merged the test coverage in 22.7
https://github.com/LabKey/targetedms/pull/588

2022-08-09 15:34 Sweta Jewargikar
resolve as Fixed
Statusopen»resolved
Assigned ToSweta Jewargikar»jeckels

2022-08-09 15:35 Sweta Jewargikar
close
Statusresolved»closed
Assigned Tojeckels»Guest