Issue 45642: Flag column in run grids is very wide now

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Experiment
Priority:3
Milestone:22.03
Opened:2022-06-08 09:18 by jeckels
Changed:2022-06-08 17:04 by vsharma
Resolved:2022-06-08 13:03 by jeckels
Resolution:Fixed
Related:45559
Support Ticket: 
Pull Requests:platform#3423
Closed:2022-06-08 17:04 by vsharma
Related Issues
2022-06-08 09:18 jeckels
Title»Flag column in run grids is very wide now
Assigned To»jeckels
Type»Defect
Area»Experiment
Priority»3
Milestone»22.03
Related»45559
My recent change to how lookup columns choose their widths has an unintended side effect for the quirky Flag column on run grids. Behind the scenes it's a lookup to the exp.FlagComment table (not exposed as a top-level table in the schema browser). It's displaying the Comment column, which is configured with a width of 200 pixels. But FlagColumnRenderer isn't rendering the comment text into the cell - it's just showing the flag icon.

The custom rendering code should handle the override of configuring the desired width, which is just wide enough to show the flag icon and column heading.

2022-06-08 09:20 jeckels
Notify»vsharma
Pull Requests»https://github.com/LabKey/platform/pull/3423

2022-06-08 13:03 jeckels
resolve as Fixed
Statusopen»resolved
Assigned Tojeckels»vsharma
Vagisha, can you verify this at your convenience? It's now merged to 22.3 and will be part of the 22.3.8 maintenance release (though you don't really care about that last bit).

2022-06-08 17:04 vsharma
close
Statusresolved»closed
Assigned Tovsharma»Guest
Verified on my dev machine. Thanks.