Issue 45643: Client side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.

issues
Status:closed
Assigned To:Guest
Type:Defect
Area:Sample Manager
Priority:2
Milestone:22.07
Opened:2022-06-08 09:31 by Dan Duffek
Changed:2022-06-21 15:10 by Dan Duffek
Resolved:2022-06-14 15:35 by Susan Hert
Resolution:Fixed
Support Ticket: 
Pull Requests:sampleManagement#992
Closed:2022-06-21 15:10 by Dan Duffek
2022-06-08 09:31 Dan Duffek
Title»Client side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.
Assigned To»triage
Notify»Susan Hert;hannahb
Type»Defect
Area»Sample Manager
Priority»2
Milestone»22.07
Not sure about when this should be fixed. Set priority to 2 because it is an unhandled exception.

In a sample type create two samples that will be used as parents for a third sample.
    One of the parent samples needs to have a comma in its name. (e.g. Parent_01 and Parent, 02)
From the sample type grid select the "Add manually" menu option.
In the create page select the sample type as a parent sample type
Add the two parents samples as parents
Create the sample.
In the new samples detail page go to the timeline tab
    There should be one event, the sample registered event.
Click the event to get the details.

Result:
Unhandled client side error:
Error. undefined: undefined
URL. http://localhost:8080/labkey/SM_Daily/sampleManager-app.view#/samples/sampletype_02/12038/Timeline

Attached screen shot has the component stack trace.

Both parents are needed. If I created a sample with only a "comma" parent there was no problem.
I don't think the order in which the parents are added makes any difference.
 
 Screen Shot 2022-06-08 at 9.27.29 AM.png

2022-06-09 11:56 hannahb
Assigned Totriage»Susan Hert
Not sure how reasonable this is to get into 22.7 - maybe we could add to a 22.7.x maintenance release for the client that may need this?

2022-06-13 19:18 Susan Hert
TitleClient side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.»**Client side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.

2022-06-14 15:35 Susan Hert
resolve as Fixed
Title**Client side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.»Client side error when looking at a samples create time line event detail when the sample has a multiple parents and one has a comma in its name.
Statusopen»resolved
Assigned ToSusan Hert»Dan Duffek
Pull Requests»https://github.com/LabKey/sampleManagement/pull/992
Merged to develop

2022-06-21 15:10 Dan Duffek
close
Statusresolved»closed
Assigned ToDan Duffek»Guest
Validated.