Issue 45688: Cannot Approve Large Notebooks

issues
Status:closed
Assigned To:Guest
Type:Defect
Area: 
Priority:3
Milestone:22.08
Opened:2022-06-14 16:57 by alanv
Changed:2022-07-11 09:35 by ChrisJ
Resolved:2022-06-28 14:49 by Karl Lum
Resolution:Fixed
Related:45672, 45708
Support Ticket:45672
Pull Requests:compliance#160
platform#3483
labbook#219
Closed:2022-07-11 09:35 by ChrisJ
Related Issues
2022-06-14 16:57 alanv
Title»Cannot Approve Large Notebooks
Assigned To»alanv
Notify»Karl Lum;Nick Kerr;Bernie;hannahb;Andrew
Type»Defect
Priority»3
Milestone»22.07
Support Ticket»45672
Notebooks that result in a signed snapshot that is > 50MB throw an error when approved.

To reproduce this issue:
1. Create a Notebook
2. Attach several large files to the notebook or to an entry of the notebook. These files must collectively be greater than 50MB
3. Submit the notebook
4. Approve the notebook

Expected Results: The notebook is approved
Actual Results: Notebook approval fails when generating the signed snapshot, and an error is rendered:

"File Biologics_2022-06-14-_18-44-01.notebook-snapshot.zip is larger htan the maximum allowed size. 57,263,876 vs 50,000,000 bytes"

(see attached screenshot)

If I delete enough attachments I can submit the notebook.

I am not totally sure what exactly we should do in this case. It seems obvious to me that we should not be using the same limit we use for other blobs, as this seems like it will be common to encounter. I am wondering if we should have no upper limit, warn about size, or do something else.

2022-06-14 16:58 alanv

2022-06-14 16:58 alanv

2022-06-15 09:44 alanv
I have a repro for another scenario encountered by a user in the wild:

1. Create a Notebook
2. Embed several large images into the entry (on OS X go to an image in finder, CMD + C the image, then go to the entry and hit CMD + V). These files must collectively be greater than 50MB
3. Wait at least 5 minutes, then remove the images from the entry
4. Submit the notebook
5. Approve the notebook

Expected Results: The notebook is approved
Actual Results: Notebook approval fails when generating the signed snapshot, and the same type of error as previously reported is rendered.

This case is especially confounding because to the user there are no attachments. What we are probably doing is exporting all embedded images associated with each entry's wiki, even if they're not associated with the most recent version of an entry. Instead, what we should be doing is only exporting embedded attachments associated with the most recent wiki version of each entry. We may consider this a separate bug, because even if we weren't hitting the upper limit for files we'd be exporting unnecessary information which is likely to be confusing.

2022-06-15 13:20 hannahb
Related»45672

2022-06-16 14:22 alanv
Related45672»45672, 45708

2022-06-16 14:23 alanv
I created a separate issue for the embedded attachments problem outlined above. This issue should be focused on the file size problem.

2022-06-16 14:26 alanv
Assigned Toalanv»Karl Lum

2022-06-24 15:11 Karl Lum
Pull Requests»https://github.com/LabKey/compliance/pull/160 https://github.com/LabKey/platform/pull/3483 https://github.com/LabKey/labbook/pull/219

2022-06-28 14:49 Karl Lum
resolve as Fixed
Statusopen»resolved
Assigned ToKarl Lum»alanv

2022-06-29 12:01 Nick Kerr
Assigned Toalanv»ChrisJ
Milestone22.07»22.08
Resolving to Chris for regression test coverage.

2022-07-11 09:35 ChrisJ
close
Statusresolved»closed
Assigned ToChrisJ»Guest