Issue 45704: Multiple error messages provide less detail than a single error message during dataset creation

issues
Status:resolved
Assigned To:Keith
Type:Defect
Area:Study
Priority:3
Milestone:22.07
Opened:2022-06-16 10:48 by Keith
Changed:2022-08-02 13:39 by cnathe
Resolved:2022-08-02 13:39 by cnathe
Resolution:Fixed
Related:45670
Support Ticket:45670
Pull Requests:labkey-ui-components#924
platform#3575
Closed:
2022-06-16 10:48 Keith
Title»Multiple error messages provide less detail than a single error message during dataset creation
Assigned To»triage
Type»Defect
Area»Study
Priority»3
Milestone»22.07
Related»45670
Support Ticket»45670
A client recently encountered an error while creating a dataset. The file actually had three errors; the client saw this error (screenshot attached): There are three field entry errors. Please correct the errors in Fields before saving.

For a file with a single error, the error message provides more detail and is much more helpful (example attached).

Can we amend the multiple error message to state the number of errors and give more detail, perhaps with a bullet for each error. For example:

There are three field entry errors:
-The field name 'Aroma Tech' is already taken. Please provide a unique name for each field.
-The field name 'R&G Split Rate' is already taken. Please provide a unique name for each field.
-The field name Split' is already taken. Please provide a unique name for each field.

 Please correct the errors in Fields before saving.
 
 Multiple Errors.png
 Single Error.png

2022-06-27 09:29 hannahb
Assigned Totriage»Karl Lum
Milestone22.07»22.11
Karl, is there any reason we're not matching functionality on field errors with Lists and other data types (see example)? Could we please estimate what it would take to match it?
 
 Screen Shot 2022-06-21 at 11.39.43 PM.png

2022-08-01 17:16 Karl Lum
Assigned ToKarl Lum»cnathe
My impression was that the client side code was the same but it's possible that the dataset designer is different because of the mapping section below fields. Cory is probably a better person (or someone who worked on the domain editor conversion)

2022-08-02 10:53 cnathe
TitleMultiple error messages provide less detail than a single error message during dataset creation»**Multiple error messages provide less detail than a single error message during dataset creation
Milestone22.11»22.07
Pull Requests»https://github.com/LabKey/labkey-ui-components/pull/924 https://github.com/LabKey/platform/pull/3575
The issue was that we were skipping the attempt to align the error message from the server with the domain field rows in the case there the dataset column mappings where set. This has been changed/fixed and is targeting 22.7.

2022-08-02 13:39 cnathe
resolve as Fixed
Title**Multiple error messages provide less detail than a single error message during dataset creation»Multiple error messages provide less detail than a single error message during dataset creation
Statusopen»resolved
Assigned Tocnathe»Keith
Fix has been merged to release22.7-SNAPSHOT and will be in LK v22.7.2